Irachkom wrote:and hit>crit for all casters.
Hit is actually very, very slightly worse than crit for warlocks (because of improved shadowbolt talent), but there's no opportunities for you to meaningfully exercise that information. Caster gear in this game is incredibly linear, it's perfectly reasonable to treat crit and hit as equivalent, except hit can be capped and does basically nothing in pvp after the first few %.
Crit
probably ends up being better for fire mages (during AQ40+) on the basis of them reaching the hit cap very easily, but I haven't crunched the numbers on that, so I can't say.
For rogue AP, it depends if you're dagger or sword, and it depends if you're horde or alliance. You can check out some estimates here:
https://forum.nostalrius.org/viewtopic.php?f=37&t=5412