modui

[Noxm]

You need to delete the addons folder name -master..

Wrong : Modui-master Good : Modui

[forsaken_toys]

Hi there!
sometimes I get this bug with key-chain.

Can't catch 100% conditions. If you need something to test on my computer or at least addons list, let me know!

[kuurtzen]

keyring up to its old antics again

[modernist]

oh good that bug again. can you tell me if it starts happening after you open your bank frame?

[forsaken_toys]

oh good that bug again. can you tell me if it starts happening after you open your bank frame?

Nope, tried this, key chain is ok.

[semtex89]

Have a question

Is it possible to remove showing hunter/lock pets nameplates?

[snawfu]

Target of target how to show, I tried searching through this topic but maybe I'm confused.

I have no other addons turned on.


edit: found some text about it after looking around in the lua but still won't show in game. Did a full WTF delete as well D:

[modernist]

[modernist]

Have a question

Is it possible to remove showing hunter/lock pets nameplates?

not as far as i know I'm afraid — i'll have a quick look later though

[Roadblock]

Have a question

Is it possible to remove showing hunter/lock pets nameplates?

not as far as i know I'm afraid — i'll have a quick look later though

I'm testing an experimental feature in CustomNameplates for just this.
It works pretty well but the performance when initially populating the player and playerpet registry is abominable.

It smooths out after it has scanned new players in the vicinity but when entering a heavily populated area for the first time it stutters visibly.

The concept is that in the scanning part where you populate a table with players you do this instead:

Code: Select all

if UnitIsPlayer("target") then
  local _, class = UnitClass("target") -- use the locale-agnostic value
  table_insert(Players, name)
  Players[name] = {["class"] = class}
elseif UnitPlayerControlled("target") and UnitCreatureFamily("target")~=nil then -- should be a player pet
  PlayerPets[name] = true
end

Then you can

Code: Select all

if PlayerPets[name] then --[[hide]] end

someplace else.

I took a look at your nameplates, I see they borrow heavily from the original addon I used for CustomNameplates, so you probably can benefit from some of the optimizations I've done (for example not looping through all the cosmetic pet names for each check)

Hope it helps, I'm not using modui myself but it's a great UI

PS. table_insert is an upvalue of table.insert and PlayerPets is a table initialized elsewhere.
PPS. My work in progress code: https://github.com/Dridzt/CustomNameplates