modui

Re: modui

by modernist » Sun Jan 17, 2016 9:39 pm

thanks, interesting to see — i'l give it a try and look at the benefits and drawbacks upon performance. I've been meaning to check your other improvements for CN too, especially your solution for throttling onupdate
modernist
Sergeant Major
Sergeant Major
 

Re: modui

by AfterAfterlife » Sun Jan 17, 2016 11:52 pm

Roadblock wrote:It works pretty well but the performance when initially populating the player and playerpet registry is abominable.

It smooths out after it has scanned new players in the vicinity but when entering a heavily populated area for the first time it stutters visibly.

I took the liberty to check the code and here's an idea. Instead of making a single update function (i.e. only one "object" doing all the job every single frame), divide that update function into 2 functions:
  • Main one (that was not causing any problems before) - This one is called in every single frame.
  • The new feature (hide players' pets nameplates) - This one could be called every 0.05secs, allowing to the CPU to breathe. Or it could be simply called when a new nameplate appears in the screen.
AfterAfterlife
Grunt
Grunt
 

Re: modui

by Roadblock » Mon Jan 18, 2016 12:30 am

AfterAfterlife wrote:I took the liberty to check the code and here's an idea. Instead of making a single update function (i.e. only one "object" doing all the job every single frame), divide that update function into 2 functions:
  • Main one (that was not causing any problems before) - This one is called in every single frame.
  • The new feature (hide players' pets nameplates) - This one could be called every 0.05secs, allowing to the CPU to breathe. Or it could be simply called when a new nameplate appears in the screen.

I have a couple passes to do in general, so this is not final code was just putting something out to test if the pet detection method I came up with, even works :).
Thanks for the suggestion, I already throttle my updates, they don't happen every frame.
Trying to slow the refresh rate too much will cause "blinking" (you'd see the affected nameplates pop in or pop out depending on settings)
Astaldo @ Nostalrius PvE (Alliance)
Addons I've posted on Forum
User avatar
Roadblock
Senior Sergeant
Senior Sergeant
 

Re: modui

by forsaken_toys » Mon Jan 18, 2016 11:59 am

Hi Modernist, I've spotted one more weird bug. I'm using DamageMeters addon, so when I'm unchecking both options in status text option window, instead of showing all names on DM bars I got them all on my name frame.
Image
If I check one of them, everything is on its places.
Image
Maybe some thirdparty addon messes things up, not sure. I'm addon addicted, can list all of them if you want.
forsaken_toys
Sergeant
Sergeant
 

Re: modui

by modernist » Mon Jan 18, 2016 12:54 pm

hey thats a pretty good bug — i think i can guess what the problem is, i'll see if i can upload a fix tonight for you
modernist
Sergeant Major
Sergeant Major
 

Re: modui

by forsaken_toys » Mon Jan 18, 2016 2:02 pm

Hey, no rush, it doesn't bother me at all, I'm just reporting in general "improve things you like" sense =)
forsaken_toys
Sergeant
Sergeant
 

Re: modui

by forsaken_toys » Mon Jan 18, 2016 2:32 pm

Also, for this server and their anticheat, could you add some slow down for selling gray items? Getting D/C'ed every time if I have more than 4 or 5 items.

And one more idea for modui, bags and vendoring. Pretty often I get some white items like gear and weapons, which generally same grey vendor garbage, or some meat/spider ichor which is so cheap, that I can't even sell on AH, because deposit is bigger than stack price :D

I was trying to find any addon which could add something to garbage list and vendor it with gray things. Would be awesome, if I could mark something with alt-click as garbage.
forsaken_toys
Sergeant
Sergeant
 

Re: modui

by MonroeX » Tue Jan 19, 2016 12:36 am

Hey modernist!

Huge fan of modui as a whole :) I just have an issue with the lions on the sides of the actionbar go over my leftmost and rightmost top actionbar spell. Is there a setting to remove the lions?
Image
User avatar
MonroeX
Sergeant
Sergeant
 

Re: modui

by modernist » Tue Jan 19, 2016 12:43 am

Yeah, check the 'display' tab of the options window (click the M on the main bar to the left of the bag slots)
modernist
Sergeant Major
Sergeant Major
 

Re: modui

by djmy » Tue Jan 19, 2016 1:09 am

I've searched on page 6-7 on how to move the tooltip since it's all the way at the bottom when I mouseover something and I'm really confuse on how to do so. Moveanything doesn't really help and I've been trying to figure this out the pass hour lol.

-Thanks
djmy
Grunt
Grunt
 

PreviousNext

Return to Addons & macros